[Fix 17.0] hr_expense_invoice #274
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the correct partner, from current expense line from the report, not always the same partner from first expense line
|
Please use proper commit message: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message and respect pre-commit formatting. |
TheCloneMaster
changed the title
|
Hope it has correct format now |
|
The commit message and pre-commit stays the same:
You can't amend it from GitHub. You need to do another edit/PR, or use your computer to pull the branch, amend it, and push again. The proper commit message is: |
Fix ruff error on bad binding of "expense" variable on lambda function
|
I think I better close this one, and try again with your guidelines! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue:
#273
If an expense report includes invoices from diferent providers, when posting move the report moves to "paid" and invoices are not reconciled as paid, as it fails to reconcile the lines with the transfer moves.
Use the correct partner, from current expense line from the report, not always the same partner from first expense line